This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Deployment: remove replicas=1 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jjo ! @jbianquetti-nami do you mind taking a look at this tiny PR when you get a chance ? |
jbianquetti-nami
approved these changes
Aug 25, 2022
Aman1994
pushed a commit
to Aman1994/k8id
that referenced
this pull request
Feb 1, 2023
> Also it appears that it is not easy to remove a field in jsonnet once it is set, so it is better to just not set it. bitnami/kube-libsonnet#74
Aman1994
pushed a commit
to Obmondo/kubeaid
that referenced
this pull request
Feb 1, 2023
> Also it appears that it is not easy to remove a field in jsonnet once it is set, so it is better to just not set it. bitnami/kube-libsonnet#74
KlavsKlavsen
pushed a commit
to Obmondo/kubeaid
that referenced
this pull request
Feb 2, 2023
> Also it appears that it is not easy to remove a field in jsonnet once it is set, so it is better to just not set it. bitnami/kube-libsonnet#74
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
replicas: 1inside the Deployment object.Motivation
For Horizontal Pod Autoscaler to work properly with gitops systems such as ArgoCD, FluxCD, Deployment objects shouldnt' have
replicasset. The defaultreplicasis 1 so this is safe to be removed.Also it appears that it is not easy to remove a field in jsonnet once it is set, so it is better to just not set it.
References
replicas: 1in a deployment is detrimental #58